Pull request #146: old defaultMessageStorage Methods removed

Merge in MML/infobip-mobile-messaging-react-native-plugin from okoroleva-PZ-794-obsolete_storage_methods to master Squashed commit of the following: commit 15a0b67ab698fc82339a3350719c369e9ed76232 Author: Olga Koroleva <[email protected]> Date: Mon Dec 16 16:35:35 2024 +0100 changed the typescript DefaultMessageStorage methods description commit 7be7c77095ec0b7600bc51e450fa9bc2cda94fa5 Author: Olga Koroleva <[email protected]> Date: Mon Dec 16 16:20:28 2024 +0100 old defaultMessageStorage Methods removed
infobip · Dec 17, 2024 · 1eb0977 · 1eb0977
1 parent 0610b06
commit 1eb0977
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 63 deletions.
diff --git a/.../main/java/org/infobip/reactlibrary/mobilemessaging/ReactNativeMobileMessagingModule.java b/.../main/java/org/infobip/reactlibrary/mobilemessaging/ReactNativeMobileMessagingModule.java
@@ -876,65 +876,6 @@ protected Void doInBackground(Void... params) {
         }.execute();
     }
 
-    @ReactMethod
-    public synchronized void defaultMessageStorage_find(String messageId, final Callback callback) throws JSONException {
-        MessageStore messageStore = MobileMessaging.getInstance(reactContext).getMessageStore();
-        if (messageStore == null) {
-            callback.invoke();
-            return;
-        }
-
-        for (Message m : messageStore.findAll(reactContext)) {
-            if (messageId.equals(m.getMessageId())) {
-                callback.invoke(ReactNativeJson.convertJsonToMap(MessageJson.toJSON(m)));
-                return;
-            }
-        }
-        callback.invoke();
-    }
-
-    @ReactMethod
-    public synchronized void defaultMessageStorage_findAll(final Callback callback) throws JSONException {
-        MessageStore messageStore = MobileMessaging.getInstance(reactContext).getMessageStore();
-        if (messageStore == null) {
-            callback.invoke();
-            return;
-        }
-        List<Message> messages = messageStore.findAll(reactContext);
-        callback.invoke(ReactNativeJson.convertJsonToArray(MessageJson.toJSONArray(messages.toArray(new Message[messages.size()]))));
-    }
-
-    @ReactMethod
-    public synchronized void defaultMessageStorage_delete(String messageId, final Callback callback) throws JSONException {
-        MessageStore messageStore = MobileMessaging.getInstance(reactContext).getMessageStore();
-        if (messageStore == null) {
-            callback.invoke();
-            return;
-        }
-
-        List<Message> messagesToKeep = new ArrayList<Message>();
-        for (Message m : messageStore.findAll(reactContext)) {
-            if (messageId.equals(m.getMessageId())) {
-                continue;
-            }
-            messagesToKeep.add(m);
-        }
-        messageStore.deleteAll(reactContext);
-        messageStore.save(reactContext, messagesToKeep.toArray(new Message[messagesToKeep.size()]));
-        callback.invoke();
-    }
-
-    @ReactMethod
-    public synchronized void defaultMessageStorage_deleteAll(final Callback callback) {
-        MessageStore messageStore = MobileMessaging.getInstance(reactContext).getMessageStore();
-        if (messageStore == null) {
-            callback.invoke();
-            return;
-        }
-        messageStore.deleteAll(reactContext);
-        callback.invoke();
-    }
-
     /**
      * Message store adapter for JS layer
      */

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -168,13 +168,13 @@ declare namespace MobileMessagingReactNative {
     }
 
     export interface DefaultMessageStorage {
-        find(messageId: string, callback: (message: Message) => void): void;
+        find(messageId: string, onSuccess: (message: Message) => void, onError: () => void): void;
 
-        findAll(callback: (messages: Message[]) => void): void;
+        findAll(onSuccess: (messages: Message[]) => void, onError: () => void): void;
 
-        delete(messageId: string, callback: () => void): void;
+        delete(messageId: string, onSuccess: () => void, onError: () => void): void;
 
-        deleteAll(callback: () => void): void;
+        deleteAll(onSuccess: () => void, onError: () => void): void;
     }
 
     export interface CustomMessageStorage {