Skip to content

feat: show error update notebook fail #7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 6, 2025

Closes #6999

Screen.Recording.2025-04-02.at.17.40.21.mov

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners March 6, 2025 08:26
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 6, 2025
@NguyenHoangSon96 NguyenHoangSon96 changed the title feat: show error update notebook fail 1 feat: show error update notebook fail Mar 6, 2025
@wdoconnell
Copy link
Contributor

Remocal deployment failure. Re-running CI.

@philjb philjb requested a review from wdoconnell March 6, 2025 18:19
@wdoconnell
Copy link
Contributor

@NguyenHoangSon96 Looks like CI flaked, please force push to re-run this.

@NguyenHoangSon96
Copy link
Contributor Author

@NguyenHoangSon96 Looks like CI flaked, please force push to re-run this.

@wdoconnell
I have triggered CI. It's looking good now
Please check again

@NguyenHoangSon96 NguyenHoangSon96 requested review from wdoconnell and removed request for wdoconnell March 11, 2025 10:34
@NguyenHoangSon96
Copy link
Contributor Author

After fixing the result is recorded in the description above ⬆️

Copy link
Member

@blegesse-w blegesse-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing context here, but from what I can tell, this PR adds error notifications, but I am not seeing anything that address the original issue - the UI still showing "Autosaved" when an error occurs. Should there be code that updates the UI state to remove the "Autosaved" indicator when errors happen?

@NguyenHoangSon96
Copy link
Contributor Author

I might be missing context here, but from what I can tell, this PR adds error notifications, but I am not seeing anything that address the original issue - the UI still showing "Autosaved" when an error occurs. Should there be code that updates the UI state to remove the "Autosaved" indicator when errors happen?

Hi @blegesse-w
I'm not really sure, because I didn't see the "autosaved" label should be removed when an error happens in the "Expected behavior" and "Requested behaviour " section
As I understand the "autosaved" label is just there to tell the users that this page has an autosave feature

@NguyenHoangSon96 NguyenHoangSon96 added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit 4cd2963 Apr 16, 2025
8 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/show-error-update-notebook-fail-1 branch April 16, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[notebooks]: if the autosave api returns an error, the ui still shows that the notebook saved, when it didn't
3 participants