-
Notifications
You must be signed in to change notification settings - Fork 47
feat: show error update notebook fail #7021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show error update notebook fail #7021
Conversation
Remocal deployment failure. Re-running CI. |
@NguyenHoangSon96 Looks like CI flaked, please force push to re-run this. |
@wdoconnell |
After fixing the result is recorded in the description above ⬆️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing context here, but from what I can tell, this PR adds error notifications, but I am not seeing anything that address the original issue - the UI still showing "Autosaved" when an error occurs. Should there be code that updates the UI state to remove the "Autosaved" indicator when errors happen?
Hi @blegesse-w |
Closes #6999
Screen.Recording.2025-04-02.at.17.40.21.mov
Checklist
Authors and Reviewer(s), please verify the following: