chore: wrap offset_flush return in pin<box<_>> #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
consumer_pin
branch
2 times, most recently
from
1d46dad to
bb45f6f
Compare
1 task
fraidev
changed the title
fraidev
changed the title
sehz
reviewed
Dec 30, 2024
crates/fluvio/src/consumer/stream.rs
Outdated
| @@ -19,7 +20,7 @@ pub trait ConsumerStream: Stream<Item = Result<Record, ErrorCode>> + Unpin { | |||
| fn offset_commit(&mut self) -> Result<(), ErrorCode>; | |||
|
|
|||
| /// Send the committed offset to the server. The method waits for the server's acknowledgment before it finishes. | |||
| fn offset_flush(&mut self) -> impl Future<Output = Result<(), ErrorCode>> + Send; | |||
| fn offset_flush(&mut self) -> Pin<Box<dyn Future<Output = Result<(), ErrorCode>> + Send + '_>>; | |||
There was a problem hiding this comment.
can you try to alias this type so can reuse?
There was a problem hiding this comment.
sure! what do you think:
type OffsetFlushFuture<'a> = Pin<Box<dyn Future<Output = Result<(), ErrorCode>> + Send + 'a>>;
fraidev
force-pushed
the
consumer_pin
branch
from
bb45f6f to
3ceb474
Compare
sehz
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need that changes to be able to store dynamic
ConsumerStreamin a struct for infinyon/fluvio-client-python#541Remembering that we can't use generics with pyo3 structures.