infinum/feature/combine-pagination-refactor

[Antonijo2307]

…ct...

Description

Please include a summary of the feature you have added.

Checklist:

• Have checked there is no same component already in catalog.
• Have created a sufficient example or wrote tests for it.
• Code is structured, well written using standard Swift coding style.
• All public methods and properties have meaningful and concise documentation.
• Used public modifier for all method and properties that could be changed from user of your feature, and private for internal properties.
• Removed any reference to the project that piece of code was created in.
• Reduced the dependencies to minimum.

[ZvonimirMedak]

I'd like @kvaljeva to take a look at this once he gets a chance before we do anything else 😄

[ZvonimirMedak]

Is there a reason why you went for an implementation where you would constrain it with where instead of just making it generic? Then you wouldn't need the associatedType if I'm not mistaken 😄

Suggested change

	/// Defines template for page
	protocol Page where Item: Pageable {
	/// Constraint results to types that conform to Pageable
	associatedtype Item
	var count: Int { get }
	var next: URL? { get }
	var previous: URL? { get }
	var pages: Int { get }
	var page: Int { get }
	var results: [Item] { get }
	}
	/// Defines template for page
	protocol Page<Item: Pageable> {
	var count: Int { get }
	var next: URL? { get }
	var previous: URL? { get }
	var pages: Int { get }
	var page: Int { get }
	var results: [Item] { get }
	}

[Antonijo2307]

I have tried it and it seams that protocols can't have generics in this sense, it wont compile, it has to be associatedType. Maybe I didn't understand your suggestion

[ZvonimirMedak]

I feel like this should be something that is contained inside the interactor, what do you think @kvaljeva? Maybe we could do something more along the lines of the NetwokPaginationService we did?

[nikolamajcen]

Any status/update on this one? Its quite old, but let's decide if this will be improved and merged or closed.

[Antonijo2307]

@nikolamajcen I have updated the code, just few answers from @ZvonimirMedak and @kvaljeva are needed to continue/finish.
And also @ZvonimirMedak maybe you could show me an example of NetwokPaginationService implementation so I may better understand your concerns and maybe help a bit in that direction