Convert from ava tests to jest #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinheinze
requested changes
Jul 12, 2023
This commit addresses feedback on the test files. It removes explicit imports of globals in all test files for consistency. It also strengthens the assertions in the tests by replacing .toBeTruthy() and .toBeFalsy() with .toBe(true) and .toBe(false) respectively. Additionally, a test in test/cancellation.test.js has been converted to use async/await for better readability and understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used flame and GPT-4 to convert the test code base from ava to jest.
Full explanation in the YouTube video I made about it!
https://www.youtube.com/watch?v=p2mO1JiF-7U