Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
radix-vue
from the Vue version and addsfocus-trap
, which is a popular, well-maintained, framework-agnostic library. I want to move away fromradix-vue
, as it has some advantages:DialogTitle
component.Still draft because I'm investigating whether we can move away from
@headlessui/react
in the React version as well. Then we could usefocus-trap
there as well and make the two versions much more consistent.