Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove radix-vue dependency #70

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pascalbaljet
Copy link
Contributor

@pascalbaljet pascalbaljet commented Dec 18, 2024

This PR removes radix-vue from the Vue version and adds focus-trap, which is a popular, well-maintained, framework-agnostic library. I want to move away from radix-vue, as it has some advantages:

  • No more required DialogTitle component.
  • It makes it easier to implement new features in the future, such as draggable modals.
  • It reduces the UMD build from 52.73 kB (15.93 kB gzipped) to 40.32 kB (12.60 kB gzipped).

Still draft because I'm investigating whether we can move away from @headlessui/react in the React version as well. Then we could use focus-trap there as well and make the two versions much more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant