Skip to content

Commit

Permalink
Naming fixes + version bump
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalbaljet committed Nov 19, 2024
1 parent 4e9d4f2 commit d580d11
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 13 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
tests:
name: Dusk Test Inertia ${{ matrix.inertia }} - Stack ${{ matrix.stack }}
name: Dusk Inertia ${{ matrix.inertia }} (${{ matrix.stack }}), App Mounting ${{ matrix.app_mounting }}
timeout-minutes: 10
runs-on: ubuntu-latest

Expand All @@ -24,9 +24,6 @@ jobs:
inertia: [v1, v2]
stack: [react, vue]
app_mounting: [auto, custom]
exclude:
- inertia: v2
app_mounting: custom

env:
APP_URL: "http://127.0.0.1:8000"
Expand Down
2 changes: 1 addition & 1 deletion demo-app/resources/js/ModalLayout.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ModalRoot } from '@inertiaui/modal-react'

export default function Layout({ children }) {
export default function ModalLayout({ children }) {
return (
<>
{children}
Expand Down
2 changes: 1 addition & 1 deletion docs/custom-app-mounting.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ First, create a Layout component that renders the `ModalRoot` component after yo
```jsx [React]
import { ModalRoot } from '@inertiaui/modal-react'

export default function Layout({ children }) {
export default function ModalLayout({ children }) {
return (
<>
{children}
Expand Down
4 changes: 2 additions & 2 deletions react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion react/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@inertiaui/modal-react",
"author": "Pascal Baljet <[email protected]>",
"version": "0.12.1",
"version": "0.13.0",
"private": false,
"license": "MIT",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion react/src/inertiauiModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import ModalLink from './ModalLink.jsx'
import useModal from './useModal.js'

const setPageLayout = (layout) => (module) => {
module.default.layout = (page) => createElement(layout, { children: page })
module.default.layout = (page) => createElement(layout, {}, page)
return module
}

Expand Down
4 changes: 2 additions & 2 deletions vue/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vue/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@inertiaui/modal-vue",
"version": "0.12.1",
"version": "0.13.0",
"author": "Pascal Baljet <[email protected]>",
"private": false,
"license": "MIT",
Expand Down

0 comments on commit d580d11

Please sign in to comment.