[2.x] Allow environment config for ssr.enabled, ssr.url, and history.encrypt
#714
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram-pkg
changed the title
ssr.enabled and ssr.url
bram-pkg
changed the title
ssr.enabled and ssr.urlssr.enabled and ssr.url
bram-pkg
changed the title
ssr.enabled and ssr.urlssr.enabled and ssr.url
|
Looks good, added |
joetannenbaum
changed the title
ssr.enabled and ssr.urlssr.enabled, ssr.url, and history.encrypt
|
Thanks Joe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is great to be able to configure commonly changed settings through environment variables, as recommended by the 12 factor app guidelines: https://12factor.net/config.
In recent times the amount of Laravel config values exposed through environment variables has also increased by a lot.
It only makes sense to also allow for this same practice with Inertia.