Skip to content
This repository was archived by the owner on Jun 16, 2021. It is now read-only.

Varghese robin newspost detail fixes #10

Open
codein wants to merge 7 commits into
base: master
Choose a base branch
from
+28 −10
Open

Varghese robin newspost detail fixes #10

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
06b1fc9
Fixes #1 passes test_newspost_page_title_attribute
RobinVarghese Jan 30, 2021
ce08187
Fixes #2 passes test_visitor_not_sees_edit_link and test_cms_user_see…
RobinVarghese Jan 30, 2021
0283ea2
Fixes #3 test_newspost_page_content added ids to templates
RobinVarghese Jan 30, 2021
5d4aff2
Fixes #3 test_newspost_page_content modified tests to compare text
RobinVarghese Jan 30, 2021
9df64fa
Fixes #3 modified fixture passes test_newspost_page_content
RobinVarghese Jan 30, 2021
38cb61c
FIxes #4 passes test_divesite_display_name
RobinVarghese Jan 30, 2021
88d1e41
Minor verbiage changes
RobinVarghese Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion wavepool/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ def teaser(self):

@property
def source_divesite_name(self):
return 'Industry Dive'
# Implementation based on naive assumption that URL is in a
# <protocol>://www.<hostname>.xyz/asdf-asdf-asdf format
hostname = self.source.split('/')[2].split('.')[1]
return DIVESITE_SOURCE_NAMES[hostname]
Comment on lines +35 to +38
Copy link
Author

@codein codein Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source_divesite_name was hardcoded before. I have modified this to resolve the hostname from the URL and then return the lookup from DIVESITE_SOURCE_NAMES

Copy link
Author

@codein codein Feb 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really like and prefer an implementation similar to ref in branch set_coverstory_for_front_page

    def source_divesite_name(self):
        return 'Industry Dive'
        """ Return the real divesite source name for the newspost's source
        """
        source_dive = 'Industry Dive'

        url_parts = self.source.split('/')
        dive_domain = url_parts[2]
        domain_parts = dive_domain.split('.')
        dive_domain = domain_parts[1]
        if dive_domain in DIVESITE_SOURCE_NAMES:
            return DIVESITE_SOURCE_NAMES[dive_domain]
        return source_dive

However i didn't want to just copy it


def tags(self):
return [
Expand Down