Improve typing in codegen - #252
Merged
Merged
Conversation
alexfikl
force-pushed
the
type-codegen
branch
from
November 8, 2025 10:12
9dacdac to
9ec481e
Compare
alexfikl
force-pushed
the
type-codegen
branch
2 times, most recently
from
November 8, 2025 14:27
8ab5ca2 to
334b237
Compare
alexfikl
commented
Nov 8, 2025
|
|
||
| # Start with source coefficients. Gets updated after each axis. | ||
| cur_dim_input_coeffs = src_coeffs | ||
| cur_dim_input_coeffs = cur_dim_output_coeffs = list(src_coeffs) |
Collaborator
Author
There was a problem hiding this comment.
This just gives a default value to cur_dim_output_coeffs because pyright was complaining about it. Is it confusing?
Owner
There was a problem hiding this comment.
It is confusing to me. Would it instead be possible to manufacture a list of bogus values?
Collaborator
Author
There was a problem hiding this comment.
alexfikl
force-pushed
the
type-codegen
branch
2 times, most recently
from
November 8, 2025 17:31
cd22a72 to
05fc1db
Compare
alexfikl
marked this pull request as ready for review
November 8, 2025 17:33
alexfikl
force-pushed
the
type-codegen
branch
from
November 8, 2025 17:38
05fc1db to
e511353
Compare
alexfikl
commented
Nov 8, 2025
alexfikl
force-pushed
the
type-codegen
branch
from
November 10, 2025 09:21
e511353 to
3573bde
Compare
inducer
reviewed
Nov 10, 2025
|
|
||
| # Start with source coefficients. Gets updated after each axis. | ||
| cur_dim_input_coeffs = src_coeffs | ||
| cur_dim_input_coeffs = cur_dim_output_coeffs = list(src_coeffs) |
Owner
There was a problem hiding this comment.
It is confusing to me. Would it instead be possible to manufacture a list of bogus values?
alexfikl
force-pushed
the
type-codegen
branch
from
November 10, 2025 21:12
3573bde to
61399d9
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
CallExternalRecMapperand the combine mappers machinery, as discussed.