Use the fact that helmholtz k is real for better codegen #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
reviewed
May 31, 2023
Co-authored-by: Alex Fikl <[email protected]>
|
Thanks! |
|
Hmm, whoops. The changes made sense to me, but I missed that the CIs are failing. |
isuruf
commented
May 31, 2023
sumpy/kernel.py
Outdated
| if allow_evanescent: | ||
| expr = var("exp")(var("I")*k*r)/r | ||
| else: | ||
| expr = var("exp")(var("Ik")*r)/r |
There was a problem hiding this comment.
This hack is to allow the rewrite later on. Otherwise CSE will move this to another assignment.
inducer
reviewed
Jun 1, 2023
sumpy/codegen.py
Outdated
|
|
||
|
|
||
| # {{{ helmholtz rewrite | ||
| class HelmholtzRewriter(CSECachingIdentityMapper, CallExternalRecMapper): |
There was a problem hiding this comment.
Add a docstring to explain intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.