Upgrade ImGui to latest docking versions 1.92.2 WIP #129
Merged
Conversation
As of this SSH in imgui/docking branch: b4311141947de17763d88f680c84c14379538388
Contributor
Author
|
The check failure is because ImGui is expecting the "[[likely]]" feature to work based on reported version, but it's not with ubuntu clang. Just going to have to modify the embedded imgui code to make this work, by commenting out the couple places using this. |
Owner
|
Strange that Clang++ choked on those options, but if that's the case then I don't see any real alternative but to comment out those hints. Fortunately, they're just hints and not critical to functionality. Looks good, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit in the imgui/docking branch:
ocornut/imgui@b431114