Skip to content

Upgrade ImGui to latest docking versions 1.92.2 WIP #129

Merged
indigodarkwolf merged 3 commits into
indigodarkwolf:masterfrom
reltham:upgrade_imgui
Aug 11, 2025
Merged

Upgrade ImGui to latest docking versions 1.92.2 WIP #129
indigodarkwolf merged 3 commits into
indigodarkwolf:masterfrom
reltham:upgrade_imgui

Conversation

@reltham
Copy link
Copy Markdown
Contributor

@reltham reltham commented Aug 11, 2025

This commit in the imgui/docking branch:
ocornut/imgui@b431114

As of this SSH in imgui/docking branch: b4311141947de17763d88f680c84c14379538388
@reltham
Copy link
Copy Markdown
Contributor Author

reltham commented Aug 11, 2025

The check failure is because ImGui is expecting the "[[likely]]" feature to work based on reported version, but it's not with ubuntu clang.

// Hint for branch prediction
#if (defined(__cplusplus) && (__cplusplus >= 202002L)) || (defined(_MSVC_LANG) && (_MSVC_LANG >= 202002L))
#define IM_LIKELY   [[likely]]
#define IM_UNLIKELY [[unlikely]]
#else
#define IM_LIKELY
#define IM_UNLIKELY
#endif

Just going to have to modify the embedded imgui code to make this work, by commenting out the couple places using this.

@indigodarkwolf
Copy link
Copy Markdown
Owner

Strange that Clang++ choked on those options, but if that's the case then I don't see any real alternative but to comment out those hints. Fortunately, they're just hints and not critical to functionality.

Looks good, thanks for the PR!

@indigodarkwolf indigodarkwolf merged commit fae9f1a into indigodarkwolf:master Aug 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants