Show full VRAM extents, and display window overlay on preview#128
Merged
Conversation
Contributor
Author
|
gah I didn't test on 32-bit - looks like I should have done a cast on the std::min call. it will still compile and work if warnings are ignored. let me know if you want me to do another PR. |
Owner
|
Yes, please fix the 32-bit build warnings and update the PR. Also, for consistent style, please change Otherwise, looks good, and thanks a bunch! |
…uild warning (cast size_t to uint16_t)
Contributor
Author
|
done! I hope someone finds this useful :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VRAM preview appears to be limited to only showing up to 480 rows at a time, despite in lower bpp modes more lines being available in bitmap mode.
This changes that value to be dynamic instead of fixed so that the full VRAM can be displayed at a time.
I also added the abiliity to either Follow the tile base address from the top (current functionality) or show the full VRAM, and the option to show an overlay for the current display.
Let me know if anything needs clarification!