Assorted enhancements #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specs were failing to boot because of missing rack/handler wanted by Puma but not provided by the rack gem any more, it is now provided by rackup (separate gem) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 3-(or 4)-part PR, if you prefer that I create separate PRs please let me know.
rackgem (version >= 3 extractedrack/handlerinto the separaterackupgem). Also replaces the obsolete Polteregeist Capybara driver with the more modern Cuprite#ignoring_mutationmore useful by allowing nested calls (e.g. inside helper methods), and also allowing to call it without a block to disable/enable waiting for mutations for the rest of the spec