fix(scripts): sync profile skills on bot startup - #2157
Merged
Conversation
quechao76
requested review from
FreddieSun,
carolynli,
cassiuscai,
pfmiles,
phoenixliu,
totalfrank,
vzvince and
xxxxpenny
as code owners
September 11, 2026 15:54
Collaborator
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72e37f9b0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
carolynli
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
singlebox.sh start bots --profile-dir <dir>仅复制 profile 中的 Markdown 文件和公共bcs-coordination,遗漏各 profile 自带的skills/,导致技能未加载,源码更新也无法在启动时同步。Solution
skills/目录同步,不使用bots.json.skills筛选。start/restart都刷新技能,保留已有配置时也执行。bcs-coordination继续从 BCS 源码刷新。Validation
以下测试均通过:
bash scripts/test_singlebox_profile_skills.shbash scripts/test_bcn_plugin_source.shbash scripts/test_singlebox_rule_bots.shLC_ALL=C LC_CTYPE=C LANG=C bash scripts/test_hybrid.shgit diff --check新增测试覆盖首次复制、启动与重启刷新、增删改同步、配置和会话保留、软链接处理及复制失败,并核对卧底 profile 的实际技能文件。测试使用临时目录和服务桩,未运行真实 Bot 端到端验证。