feat(models): add Phi-4 multimodal vision support - #523
Open
zitai-wang wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #521.
Validation
upstream/mainmax_abs=0)git diff --checkpassValidation used Microsoft Phi-4-Multimodal-Instruct in BF16 on RTX 3090 GPUs. The local snapshot corresponds to ModelScope commit
7641bf905e6965ee54166808d275266371e28343and Hugging Face commit93f923e1a7727d1c4f446756212d9d3e8fcc5d81.The MLX failure is
test_mlx_decode_progress_matches_cuda_log_shape: the log is emitted to stderr but is not captured bycaplog. The same failure reproduces at cleanupstream/maincommit4cc3d38.Known limitations