Revalidate if Username gets replaced by Email #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbusemann
reviewed
May 20, 2019
|
|
||
| $usernameValidation = $this->settings['new']['validation']['username']; | ||
| if ($usernameValidation['uniqueInDb'] || $usernameValidation['uniqueInPage']) { | ||
| if (count($this->userRepository->findByUsername($user->getUsername())) > 0) { |
Contributor
There was a problem hiding this comment.
This will only work correct for uniqueInDb. A check for uniqueInPage would require a page id.
sbusemann
requested changes
May 20, 2019
Contributor
sbusemann
left a comment
sbusemann
left a comment
There was a problem hiding this comment.
I commented the line. Additionally due to GDPR we should not display, if a username is taken (Yes I know, this is not very logical, but we were advised to this, due to information disclosure possiblities)
Author
|
So i should change the error message? |
Contributor
|
Die @KonstantinSoelch I am still not sure, how to proceed here. I will rethink this, when I prepare the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156