resize card - #113
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughChangesThe dashboard authentication overlay now uses updated scroll-linked animation timing, a fixed frosted card presentation, redesigned onboarding steps, revised authentication and preview actions, and feature-pill personalization details. Dashboard authentication overlay
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Congratulations @nitinmohan18!Thank you for contributing to HyperLearningTech. Your pull request has been successfully merged into main. 📦 Merge Summary
🚀 Keep Contributing
Thank you for helping make HyperLearningTech better. Happy Coding! 🚀 |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/dashboard/auth-overlay.tsx (1)
85-116: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winInfinite decorative animations don't respect reduced-motion preference.
The floating lock (
y: [0, -5, 0]) and pulsing backlight (opacity/scale) runrepeat: Infinityunconditionally. Framer Motion providesuseReducedMotion/MotionConfigspecifically to disable non-essential motion for users who setprefers-reduced-motion.♻️ Suggested fix
+import { useReducedMotion } from "framer-motion"; ... + const shouldReduceMotion = useReducedMotion(); ... <motion.div className="relative mb-4 sm:mb-5" - animate={{ y: [0, -5, 0] }} - transition={{ duration: 4, repeat: Infinity, ease: "easeInOut" }} + animate={shouldReduceMotion ? undefined : { y: [0, -5, 0] }} + transition={{ duration: 4, repeat: shouldReduceMotion ? 0 : Infinity, ease: "easeInOut" }} >🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@components/dashboard/auth-overlay.tsx` around lines 85 - 116, Update the floating lock and pulsing backlight motion blocks in the auth overlay to respect the user’s reduced-motion preference via Framer Motion’s useReducedMotion or MotionConfig. Disable the non-essential infinite y, opacity, and scale animations when reduced motion is enabled while preserving the current animations for other users.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/dashboard/auth-overlay.tsx`:
- Around line 50-54: Add pointer-events-none to the backdrop motion.div’s
className in the frosted backdrop section, ensuring the invisible overlay cannot
intercept dashboard clicks while preserving the card UI’s explicit pointer-event
behavior.
---
Nitpick comments:
In `@components/dashboard/auth-overlay.tsx`:
- Around line 85-116: Update the floating lock and pulsing backlight motion
blocks in the auth overlay to respect the user’s reduced-motion preference via
Framer Motion’s useReducedMotion or MotionConfig. Disable the non-essential
infinite y, opacity, and scale animations when reduced motion is enabled while
preserving the current animations for other users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cb604643-68a5-43a0-8cde-c4a516c728d3
📒 Files selected for processing (1)
components/dashboard/auth-overlay.tsx
Summary by CodeRabbit
New Features
Bug Fixes