classification integration resources#486
Merged
Merged
Conversation
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
had a problem deploying
to
test
GitHub Actions
Failure
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
had a problem deploying
to
test
GitHub Actions
Failure
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
hadar-timan
approved these changes
Aug 7, 2025
|
|
||
| resource "aws_s3_bucket" "scan_results_bucket" { | ||
| count = var.create_classification_integration_resources ? 1 : 0 | ||
| bucket = join("-", [local.deployment_name_salted, "scan", "results", "bucket"]) |
Collaborator
There was a problem hiding this comment.
can you rename it to fam_scan_results_bucket? also, there should be a unique identifier and Im not sure the deployment_name_salted is unique... also, I'll put the identifier in the end
Collaborator
Author
There was a problem hiding this comment.
I can change the name, it salt should make it unique.
In dsfkit we always put the deployment_name_salted at the beginning.
|
|
||
| resource "aws_sqs_queue" "scan_results_bucket_notifications_sqs" { | ||
| count = var.create_classification_integration_resources ? 1 : 0 | ||
| name = join("-", [local.deployment_name_salted, "scan", "results", "bucket", "notifications", "sqs"]) |
Collaborator
There was a problem hiding this comment.
please add fam in the beginning, and if you can move the deployment salt to the end it will be also great
Collaborator
Author
There was a problem hiding this comment.
Same.
I can change the name, it salt should make it unique.
In dsfkit we always put the deployment_name_salted at the beginning.
|
|
||
| resource "aws_iam_policy" "classification_integration_policy" { | ||
| count = var.create_classification_integration_resources ? 1 : 0 | ||
| name = join("-", [local.deployment_name_salted, "classification", "integration", "policy"]) |
Collaborator
There was a problem hiding this comment.
same comment as above regarding the fam and the deployment salt
sivan-hajbi-imperva
force-pushed
the
classification_integration_resources
branch
from
ff9cbec to
db38b99
Compare
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
sivan-hajbi-imperva
temporarily deployed
to
test
GitHub Actions
Inactive
hadar-timan
approved these changes
Aug 10, 2025
lindanasredin
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.