actually use passed in networking#475
Merged
Merged
Conversation
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
3d9ba94 to
33162f6
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
33162f6 to
c8385fa
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
c8385fa to
daf208f
Compare
Collaborator
|
I see that 'terraform plan' is failing in the action. |
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
daf208f to
fd76753
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
fd76753 to
68c90ac
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
94efde3 to
3458303
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
3 times, most recently
from
33d808b to
84789b7
Compare
jsonar-cpapke
force-pushed
the
cpapke/fixup-networking
branch
from
84789b7 to
c41b1d0
Compare
Collaborator
|
Now apply is failing. |
Collaborator
Author
|
@lindanasredin looks like everything is working now |
lindanasredin
requested changes
Jul 6, 2025
| description = "The ID of an existing subnet to put all resources in. Either 'subnet_id' or 'subnet_ids' should be provided but not both." | ||
| } | ||
|
|
||
| variable "subnet_ids" { |
Collaborator
There was a problem hiding this comment.
Since we don't have an installation example in Azure, only this POC example, we need to allow the customer to deploy on different subnets.
Collaborator
Author
There was a problem hiding this comment.
After 3 days of trying to make that work, I don't think I can. I need to be able to pass in a subnet, but I can't get it to use more than one, and since it wasn't using any passed in earlier, if we need more than one that should be done in the future.
lindanasredin
approved these changes
Jul 9, 2025
jagdeep-sonar
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieve and use full list of all subnet's address spaces for allowed cidrs