dsfkit with cm (#472)#473
Conversation
sivan-hajbi-imperva
had a problem deploying
to
test
GitHub Actions
Failure
sivan-hajbi-imperva
had a problem deploying
to
test
GitHub Actions
Failure
| } | ||
|
|
||
| validation { | ||
| condition = var.ciphertrust_password == null || can(regex("[!@#$%^&*(),.?\":{}|<>]+", var.ciphertrust_password)) |
There was a problem hiding this comment.
The special characters here are different from what we have for DAM and DRA. Where do they come from? I don't see dash or underscore
There was a problem hiding this comment.
I took it from the other terraform, but they might be allowed, I need to check it
| } | ||
| } | ||
|
|
||
| variable "ciphertrust_password" { |
There was a problem hiding this comment.
Why do we need a separate password variable for CM while so far we used the same password for Sonar, MX and DRA?
There was a problem hiding this comment.
The CM policy password length is 8-30, for MX it's 7-14, I didn't want to reduce the max length in many chars, but if it is "just" poc example I can you the existing password, but need to increase the min length to 8.
Anyway if it is null, it used the same generated password that used to hub, dam, dra.
What do you think?
| workstation_cidr_24 = [format("%s.0/24", regex("\\d*\\.\\d*\\.\\d*", module.globals.my_ip))] | ||
| deployment_name_salted = join("-", [var.deployment_name, module.globals.salt]) | ||
| password = var.password != null ? var.password : module.globals.random_password | ||
| ciphertrust_password = var.ciphertrust_password != null ? var.ciphertrust_password : module.globals.random_password |
There was a problem hiding this comment.
again why does ciphtertrust get to have its own password? while all the others have the same password
sivan-hajbi-imperva
had a problem deploying
to
test
GitHub Actions
Failure
| ssh_public_key_name = module.key_pair.key_pair.key_pair_name | ||
| } | ||
| os_type = each.value.os_type | ||
| attach_persistent_public_ip = true |
There was a problem hiding this comment.
we can add variables later
…ar version 15 only (not 4.19 or 4.18) until compability issue is resolved
…tion will be handled
sivan-hajbi-imperva
force-pushed
the
dsfkit_with_cm_dev
branch
from
0aa1257 to
8eb14ca
Compare
3 participants
No description provided.