fix & feat: longstanding bugs, shit refactor#648
Open
Inconnu1337 wants to merge 2 commits intoimperial-space:developfrom
Open
fix & feat: longstanding bugs, shit refactor#648Inconnu1337 wants to merge 2 commits intoimperial-space:developfrom
Inconnu1337 wants to merge 2 commits intoimperial-space:developfrom
Conversation
github-actions
bot
added
size/Medium
Change Wiz Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
О ПР`е
Исправлены следующие баги:
Рефакторнуты следующие системы:
CultCastSystem.csMedievalReviveSystem.csОстальное:
Технические детали
CultCastSystem теперь работает на прототипах, а не жестко захардкоженных значениях. Это все еще не идеально(будет дорабатываться), но лучше, чем было. (см.
Resources\Prototypes\Imperial\Medieval\Cult\blood_spells.yml).MedievalReviveSystem менее говнокодная, все.
CultMemberComponent.Death
Cusre=> CultMemberComponent.DeathCurse.CultMemberComponent.
parent => CultMemberComponent.Parent.Medieval
BlodedComponent.cs = > MedievalBloodedComponent.о нет нет еще очень важный чейнджлог:
удален бесполезный лог
Log.Info("1");в MeleeWeaponSystemпереименован неймпспейс Content.Server.Imperial.Medieval.Cult.Bloodspells.mateials; в Content.Server.Imperial.Medieval.Cult.Bloodspells.Materials; (это конец)
В будущем будет рефакторнута система рун культа, будет красивый гайдбук вместо этой ужасной книжки и возможность создавать руны на прототипах