Fix leaking args in analysis/test's main
#653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t `.into_raw()`ing the `CString`s, but storing them in a `Vec` and using `.as_ptr()`.
fw-immunant
approved these changes
Aug 29, 2022
|
I'm not sure if this portion of the code was output of the transpiler or not. We should check that this behavior you've fixed isn't present generally. |
|
I think (?) it is. I opened #649 for that, but wanted to fix it here first since it's simpler. |
|
Ah, ok -- missed #649. That sounds good. |
This was referenced Sep 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the memory leakage of
argsinmaininanalysis/testby not.into_raw()ing theCStrings, but storing them in aVecand using.as_ptr().Checked by
miri(in #650) to remove the leaks created inmain.