Support testing non-native targets #429
Conversation
|
I moved the installation stuff to
We can keep discussing whether to use |
|
Removed any dependencies on It does this by generating a
Also, the arm tests that are failing are temporarily fixed/skipped until we figure out how to actually fix them so that we don't cause CI failures. See #431, #430, and #433. Speaking of CI, these changes, once approved (@thedataking), need to also be pushed to |
kkysen
changed the title
using `qemu` for emulation and `cargo-zigbuild` and `zig cc` for cross-compilation.
Specifically, ...
`cargo-zigbuild` is used in place of `cargo`
for building and running the test crates.
It uses `zig cc` as the linker, which has seamless cross compilation.
`qemu` is used to emulate other targets and architectures.
These are small test programs, so this should be fine,
and doing it this way allows all tests to be run locally,
which is very convenient.
I wasn't sure how dependencies should be managed,
but for this, I just had them installed in `test_translator.py` itself,
assuming it's running Ubuntu Linux.
If there's a better way to do this, let me know,
but I just did it inline first to make things quick.
Specifically,
* `cargo-zigbuild` is installed using `cargo install`
* `zig cc` is installed through `pip install ziglang` (added it to `requirements.txt`)
* `rustc` targets are installed through `rustup target add`
* `qemu` is installed through `apt` (`qemu-user`, `qemu-user-static`)
* `qemu` dynamic libraries are installed through `apt` (`gcc-${triple}`)
* `update-binfmts` (for enabling `qemu` `binfmt_misc` support) is installed through `apt` (`binfmt-support`)
… matches (since Rust uses `zig cc`, too).
…ts/provision_cross_tests.sh` instead of `scripts/test_translator.py`, which now just assumes they're already there.
And forgot to remove the `rustup target add` stuff in the last commit.
…t need to run on one target).
It's nice to be able to run `provision_cross_tests.sh` locally as well as in CI (where `sudo` doesn't exist but you're running as root (I think)). But locally, some other commands you might not want to give sudo to. Also, don't use `cargo quickinstall` actually.
Tested using `./scripts/docker_build.sh ubuntu:focal`. The installation script (`provision_cross_tests.sh`) is run twice, once as a normal user, once as root, so that it can install it's different things.
…do it in the script outside the docker build).
…h` and `provision_rust.sh`.
…ation now. Generate a `.cargo/config.toml` file containing the necessary overrides. Specifically, the `.cargo/config.toml` contains: * the default target, so `cargo build`/`run`/`test` works * the cross compiler under `linker` * rustflags to make sure you're using gold/bfd (not lld/mold) * the qemu runner (so no `binfmt_misc` support needed anymore either) This is also useful for running `--keep rust_src` and being able to run `cargo run` yourself without any flags/overrides needed.
…We can investigate and fix for sure later.
… (unused asm arg) and clang 10 (unsupported arm scalable vector extensions).
… with a C warning that didn't show up in clang 14, which works.
…function with a C warning that didn't show up in clang 14, which works." This reverts commit af93630.
…and narrowing down the cause.
…the asm and narrowing down the cause." This reverts commit 81454b6.
…even all the asm didn't work). I think it might just be the aarch64 target on clang 10 that's the problem.
…ything (even all the asm didn't work). I think it might just be the aarch64 target on clang 10 that's the problem." This reverts commit 3dac9ef.
…nce it's specified in the generated `.cargo/config.toml` now.
…g.toml`. Usually this isn't needed, but who knows when it will be.
kkysen
force-pushed
the
kkysen/non-native-tests
branch
from
2a48d5f to
e95082b
Compare
Fixes #410.
Current Description
Added support for cross-compiling and emulation using
qemu. The targets to install are determined indocker_build.shfrom thetarget-tuplefiles and passed to theDockerfileas an argument. There it installs thegcc-${c_target}aptpackages for cross-compiling inprovision_deb.sh(as well asqemu) and the rust targets inprovision_rust.shusingrustup. Then it modifiestest_translator.pyto generate a.cargo/config.tomlfor every cross-compiling test. This sets the correctlinker,rustflags, andrunner(qemu-${arch} -L /usr/${c_target}, which means we don't need to mess withbinfmt_misceither). It also sets the default target, so we don't need to always pass--target ${target}everywhere.The existing arm tests,
asm.armandasm.aarch64, are currently failing, so they are temporarily fixed or skipped until we figure out how to actually fix them so that we don't cause CI failures. See #431, #430, and #433 (now fixed by #441) for the issues.Since this PR also changes CI, the current CI tests that are passing don't really mean anything. I've tested the changes locally on
ubuntu:focaland they pass. Once we're confident it won't break CI at all, these changes should be merged into feature/ci-dev and/or have./scripts/docker_build.sh push-allbe run.Initial Description
Added support to
scripts/test_translator.pyfor cross-compiling usingcargo zigbuildandzig ccand for emulation usingqemu.More specifically,
cargo zigbuildis used in place ofcargofor building and running the test crates. It useszig ccas the linker, which has seamless cross-compilation that just works.qemuis used to emulate other targets and architectures. These are small test programs, so this should be fine, and doing it this way allows all tests to be run locally, which is very convenient.I wasn't sure how dependencies should be managed, but for this, I just had them installed in
test_translator.pyitself, assuming it's running Ubuntu Linux. I assume there's a better way to do this that's more cross-platform, but I wasn't sure how to do that yet, so I just did it inline first to make things quick. We can fix that next. As is, it usessudoand isn't going to work in CI, but it probably will work locally.Specifically for dependencies,
cargo-zigbuildis installed usingcargo installzig ccis installed throughpip install ziglang(added it torequirements.txt)rustctargets are installed throughrustup target addqemuis installed throughapt(qemu-user,qemu-user-static)qemudynamic libraries are installed throughapt(gcc-${triple})update-binfmts(for enablingqemubinfmt_miscsupport) is installed throughapt(binfmt-support)qemubinfmt_miscentries are added throughupdate-binfmts --enableNote, however, that the
asm.armandasm.aarch64tests, the ones I was trying to test, don't appear to work out of the box. I'm not sure if the errors in them are due to something wrong in the cross compilation and emulation, are they are simply errors in the tests themselves since I assume they weren't being tested as regularly. Specifically,asm.armfails at runtime on an assertion (#431), andasm.aarch64fails to compile, saying an asm argument is unused (#430).