Add crisp tools #1505
Merged
Add crisp tools #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
force-pushed
the
fw/add-crisp-tools
branch
from
3d6e8b2 to
b14877a
Compare
Contributor
Author
|
This precedes #1477, which I'll rebase after this lands. |
thedataking
approved these changes
Dec 9, 2025
Contributor
thedataking
left a comment
thedataking
left a comment
There was a problem hiding this comment.
I'm okay merging this as-is since we've "shaken the tree" already for the comment insertion use case. I don't see a way any residual bugs would affect existing c2rust users.
kkysen
reviewed
Dec 11, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
I agree, I think we don't need to carefully review this since it's already in crisp. I did notice a few little things, though.
Also, we have to run cargo +stable in each of the tool directories. Is there a way to avoid that? Would we need an overriding rust-toolchain.toml in each of them that has channel = "stable"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Rust file splitting/merging tools from the CRISP repo, branch split-merge-rust, along with some follow-up fixes and usability improvements.