transpile: tests: rename main.c to main_fn.c since the main.rs generated is detected as a test
#1499
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/rename-main-snapshot
branch
from
38b9c42 to
9116173
Compare
Contributor
|
|
Contributor
Author
Sure I can switch to that. |
…generated is detected as a test When testing `main.c`, `main.rs` is generated, and `cargo` thinks `c2rust-transpile/tests/snapshots/main.rs` is a second `snapshots` test, in addition to `c2rust-transpile/tests/snapshots.rs`: ```shell ❯ cargo test -p c2rust-transpile error: failed to load manifest for workspace member `/home/kkysen/work/c2rust/c2rust` Caused by: failed to load manifest for dependency `c2rust-transpile` Caused by: failed to parse manifest at `/home/kkysen/work/c2rust/c2rust-transpile/Cargo.toml` Caused by: found duplicate test name snapshots, but all test targets must have a unique name ``` This was from #1447, but wasn't caught in CI because it only runs `cargo test` a single time.
kkysen
force-pushed
the
kkysen/rename-main-snapshot
branch
from
9116173 to
2132f1b
Compare
kkysen
changed the title
main.c to main_args.c since the main.rs generated is detected as a testmain.c to main_fn.c since the main.rs generated is detected as a test
Contributor
Author
Switched to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing
main.c,main.rsis generated, andcargothinksc2rust-transpile/tests/snapshots/main.rsis a secondsnapshotstest, in addition toc2rust-transpile/tests/snapshots.rs:This was from #1447, but wasn't caught in CI because it only runs
cargo testa single time.