transpile: Add varargs snapshot test #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
approved these changes
Dec 3, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Thanks! LGTM! One minor nitpick is that the arch is more commonly in front of the OS, like aarch64-unknown-linux-gnu, so change that if you want, but if it's a hassle, I don't really think it's that important.
Contributor
Author
|
Oh I can change that, hold on... |
Rua
force-pushed
the
arch-os-snapshot
branch
2 times, most recently
from
d1db833 to
b0652e2
Compare
kkysen
approved these changes
Dec 3, 2025
Contributor
Awesome! I'll merge once CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the test requested in #1443 (review).