feat: schema diff sql tools #17116
Merged
feat: schema diff sql tools #17116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
feat/schema-diff
branch
4 times, most recently
from
3d6dbea to
201d539
Compare
Comment on lines
+139
to
+146
| const sourceMap = Object.fromEntries(sources.map((column) => [column.name, column])); | ||
| const targetMap = Object.fromEntries(targets.map((column) => [column.name, column])); | ||
| const keys = new Set([...Object.keys(sourceMap), ...Object.keys(targetMap)]); | ||
|
|
||
| for (const key of keys) { | ||
| items.push(...diffColumn(sourceMap[key], targetMap[key])); | ||
| } | ||
|
|
There was a problem hiding this comment.
This happens in a couple of places here. Thoughts on extracting it into a helper function?
jrasm91
force-pushed
the
feat/schema-diff
branch
from
201d539 to
141a295
Compare
danieldietzler
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate away from TypeOrm migration generation.