feat(mobile): add ability to force view original videos #15094
Merged
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
approved these changes
Jan 5, 2025
|
You should run the dart formatter to fix the failing check. |
github-actions
bot
added
the
documentation
ovidijusr
force-pushed
the
feat/force-original-video
branch
from
4cab106 to
ff7c9d8
Compare
danieldietzler
requested changes
Jan 6, 2025
ovidijusr
force-pushed
the
feat/force-original-video
branch
from
19f8db0 to
93194e2
Compare
ovidijusr
force-pushed
the
feat/force-original-video
branch
from
93194e2 to
fe247c6
Compare
danieldietzler
approved these changes
Jan 6, 2025
mertalev
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I discovered some interesting use case with AV1 videos on older (iphone 14 and below) devices: #15048
If I transcode my library to av1, (which I do becouse browsers don't support original .MOV files) I lose ability to view videos on my iphone, it tries to open av1, but video doesn't work (shows a single frame with audio).
With this PR user still would be able to view original high quality HDR .MOV videos natively supported on iphone and also would be able to access transcoded videos in browsers.
This is my first PR so feel free to comment any uncertainties.