Create dns_query_service.dart and Add some code in api.service to Fix #14938 #14955
+143
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNS Query Service
Resolves the server endpoint and sets the base path for the API client. If DNS resolution fails, it falls back to the original server URL. Logs the resolution process for debugging.
|
Thanks for the PR! I don't think there's any reason to be doing our own raw DNS queries. Please use either whatever builtins Dart has, or a third party library. |
|
Hello, thank you for the PR. Can you link the issue that this PR will fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a beginner and not familiar with writing code. This is also my first pull request. Please forgive me if there are any shortcomings.