chore(web): remove tree item thumbnail class 'max-h-[500px]' #14901
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MehringTing
commented
Dec 24, 2024
MehringTing
commented
mertalev
approved these changes
Dec 24, 2024
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| {#if items.length > 0} | |||
| <div | |||
| class="w-full grid grid-cols-2 sm:grid-cols-4 lg:grid-cols-6 2xl:grid-cols-8 gap-2 bg-gray-50 dark:bg-immich-dark-gray/50 rounded-2xl border border-gray-100 dark:border-gray-900 max-h-[500px] overflow-auto immich-scrollbar" | |||
| class="w-full grid grid-cols-2 sm:grid-cols-4 lg:grid-cols-6 2xl:grid-cols-8 gap-2 bg-gray-50 dark:bg-immich-dark-gray/50 rounded-2xl border border-gray-100 dark:border-gray-900 overflow-auto immich-scrollbar" | |||
There was a problem hiding this comment.
The breadcrumb navigation bar scrolls out of view due to this change. It would be better if it remained visible at the top at all times.
Since this div no longer overflows, these classes can be removed:
Suggested change
| class="w-full grid grid-cols-2 sm:grid-cols-4 lg:grid-cols-6 2xl:grid-cols-8 gap-2 bg-gray-50 dark:bg-immich-dark-gray/50 rounded-2xl border border-gray-100 dark:border-gray-900 overflow-auto immich-scrollbar" | |
| class="w-full grid grid-cols-2 sm:grid-cols-4 lg:grid-cols-6 2xl:grid-cols-8 gap-2 bg-gray-50 dark:bg-immich-dark-gray/50 rounded-2xl border border-gray-100 dark:border-gray-900" | |
There was a problem hiding this comment.
yes,It is better to fix it at the top.
MehringTing
force-pushed
the
chore/tree-item-thumbnail-max-height
branch
2 times, most recently
from
b859931 to
c1242ab
Compare
|
We need the max-height to show the assets of the nested tag/folder |
|
I think it should work like the file browser does. Having two scroll sections is weird and doesn't make good use of space. |
|
Not a bad reasoning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.