Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): add github action to validate and diff pull request #86

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

hiteshnayak305
Copy link
Contributor

@hiteshnayak305 hiteshnayak305 commented Apr 12, 2024

Description of the change

Support for validation on a pull request.

On pull request

  • helm lint is run

  • helm template is run with default pvc test-pvc to detect any compilation error

  • int128/diff-action@v1 (compare final manifest with main branch) Will only run on pull request to main and feature/pr-action branches

    1. If there is no any change in final manifest then there will be no comment. (limitation: no action on empty diff in dependency action library)

    2. If there is some change in final manifest a bot will put a comment with diff in final manifest.
      Pull Request Example

bot-diff-comment

Applicable issues

@hiteshnayak305
Copy link
Contributor Author

accepting command in comments is little tricky, please let me know if any suggestions

Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you very much!

@bo0tzz bo0tzz merged commit 00a858d into immich-app:main Apr 12, 2024
2 checks passed
@hiteshnayak305 hiteshnayak305 deleted the feature/pr-action branch April 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview diffs in PRs
2 participants