Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add startup probe for machine learning #147

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

samholton
Copy link
Contributor

I ran into issues with machine-learning pod not having enough time to download and startup after adding MACHINE_LEARNING_PRELOAD__CLIP.

@samholton samholton requested a review from bo0tzz December 7, 2024 01:59
Copy link

github-actions bot commented Dec 7, 2024

Changes in Final Manifest

  • manifest.yaml

manifest.yaml

--- a/main/charts/immich/build/manifest.yaml
+++ b/charts/immich/build/manifest.yaml
@@ -10,7 +10,7 @@ metadata:
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: machine-learning
     app.kubernetes.io/version: v1.119.0
-    helm.sh/chart: immich-0.8.4
+    helm.sh/chart: immich-0.8.5
   annotations:
 spec:
   type: ClusterIP
@@ -34,7 +34,7 @@ metadata:
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: server
     app.kubernetes.io/version: v1.119.0
-    helm.sh/chart: immich-0.8.4
+    helm.sh/chart: immich-0.8.5
   annotations:
 spec:
   type: ClusterIP
@@ -57,7 +57,7 @@ metadata:
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: machine-learning
     app.kubernetes.io/version: v1.119.0
-    helm.sh/chart: immich-0.8.4
+    helm.sh/chart: immich-0.8.5
 spec:
   revisionHistoryLimit: 3
   replicas: 1
@@ -120,6 +120,14 @@ spec:
             initialDelaySeconds: 0
             periodSeconds: 10
             timeoutSeconds: 1
+          startupProbe:
+            failureThreshold: 60
+            httpGet:
+              path: /ping
+              port: http
+            initialDelaySeconds: 0
+            periodSeconds: 10
+            timeoutSeconds: 1
       volumes:
         - name: cache
           emptyDir:
@@ -135,7 +143,7 @@ metadata:
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: server
     app.kubernetes.io/version: v1.119.0
-    helm.sh/chart: immich-0.8.4
+    helm.sh/chart: immich-0.8.5
 spec:
   revisionHistoryLimit: 3
   replicas: 1

See the workflow run

@bo0tzz bo0tzz merged commit 47d5661 into main Dec 10, 2024
1 check passed
@bo0tzz bo0tzz deleted the feat/machine-learning-startup-probe branch December 10, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants