Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request 'layers' feature in projection layer sample #204

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

toji
Copy link
Member

@toji toji commented Jan 15, 2025

While doing some testing I noticed that we didn't have any samples that utilized a projection layer without requesting the layers feature. Seems appropriate that the first layers sample could cover that case, since all other layers samples require it. What do you think, @cabanier?

@toji toji requested a review from cabanier January 15, 2025 18:19
Copy link
Member

@cabanier cabanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good point!

@toji toji merged commit b4fc6ac into main Jan 15, 2025
@toji toji deleted the projection-layer branch January 15, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants