Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown alignment #841

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix dropdown alignment #841

merged 3 commits into from
Mar 11, 2024

Conversation

bitbound
Copy link
Collaborator

@bitbound bitbound commented Mar 7, 2024

So far, I've only used the Bootstrap CSS and left out the JS, using Razor/C# for the interactive elements that didn't work with just CSS.

The dropdown component needs Popper.js for alignment options to work (which is part of the JS bundle), and I didn't want to spend the time implementing a workaround. So I brought in the JS bundle to get the dropdown working correctly.

I also reworked the modal component to use JS, so there weren't any conflicts with JS and the Razor template changes.


Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

colinblaise
colinblaise previously approved these changes Mar 8, 2024
Server/Components/DropdownButton.razor Show resolved Hide resolved
@dkattan dkattan merged commit fb9a3f7 into master Mar 11, 2024
1 check passed
@bitbound bitbound deleted the fix-dropdown-alignment branch March 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants