Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict questionnaire editing to admins if no encounters exist #172

Open
wants to merge 1 commit into
base: v3.2.1
Choose a base branch
from
Open

Restrict questionnaire editing to admins if no encounters exist #172

wants to merge 1 commit into from

Conversation

schluebbo
Copy link
Collaborator

Changes:

  • Only admins can now edit released questionnaires if no encounters exist.
  • Moderators and editors can still edit if the questionnaire is not part of an enabled bundle.
  • Adjusted role checks in QuestionnaireService.
  • Updated and extended test cases to verify the new behavior.

@schluebbo
Restrict questionnaire editing to admins if no encounters exist
bb76896 
- Changed permissions: Only admins can edit released questionnaires without encounters.
- Moderators and editors can still edit if the questionnaire is not part of an enabled bundle.
- Modified and extended test cases to ensure correct behavior.
@schluebbo schluebbo self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

Test Results:

TestsPassed ✅Skipped ⚠️Failed
JUnit Test Report1010 ran1000 passed10 skipped0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storckmi storckmi Awaiting requested review from storckmi storckmi is a code owner

@ywarnecke ywarnecke Awaiting requested review from ywarnecke ywarnecke is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@schluebbo schluebbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schluebbo