Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

159 exporting a questionnaire with an image #168

Open
wants to merge 3 commits into
base: v3.2.1
Choose a base branch
from
Open

159 exporting a questionnaire with an image #168

wants to merge 3 commits into from

Conversation

hussainsabir52
Copy link
Collaborator

Made changes to the instantiation behavior for JSON helper class

#159

@hussainsabir52 hussainsabir52 added the bug Something isn't working label Jan 27, 2025
@hussainsabir52 hussainsabir52 added this to the MoPat v3.2.1 milestone Jan 27, 2025
@github-actions GitHub Actions
Copy link

Test Results:

TestsPassed ✅Skipped ⚠️Failed
JUnit Test Report1007 ran997 passed10 skipped0 failed

@hussainsabir52 hussainsabir52 linked an issue Jan 27, 2025 that may be closed by this pull request
Exporting a questionnaire with an image throws an error #159
Open
ywarnecke
ywarnecke reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@ywarnecke ywarnecke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to see if it makes sense to let Springs Dependency Injection handle the creation of all those classes. If it does use the ConfigurationDao, it should.

@github-actions GitHub Actions
Copy link

Test Results:

TestsPassed ✅Skipped ⚠️Failed
JUnit Test Report1007 ran997 passed10 skipped0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywarnecke ywarnecke ywarnecke left review comments

@storckmi storckmi Awaiting requested review from storckmi storckmi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hussainsabir52 hussainsabir52

@ywarnecke ywarnecke

Labels
bug Something isn't working
Projects
None yet
Milestone
MoPat v3.2.1
Development

Successfully merging this pull request may close these issues.

Exporting a questionnaire with an image throws an error
2 participants
@hussainsabir52 @ywarnecke