Slight cleanup of crate::imageops::sample::filter3x3()
#2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
197g
reviewed
Sep 13, 2025
LikeLakers2
commented
Sep 13, 2025
LikeLakers2
changed the title
crate::imageops::sample::filter3x3()crate::imageops::sample::filter3x3()
…s, remove the redundant guard
|
Right. Unless anybody spots anything else, I think this PR should be good for merging - or at least, ready for final review. :) |
|
Is there anything blocking this from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing my previous PR for errors, I happened to notice that these tuples are somewhat useless. They seem to be an artifact of #384, one that wasn't cleaned up later on.
Since removing these tuples cleans up the code, and may (if rustc isn't already smart enough to detect that these tuples are useless) improve performance slightly, all without changing the behavior of the code, I went ahead and removed them.
Edit: Seems this turned into a small refactor of
filter3x3. :p