Add alpha mask utilities to ImageBuffer #2544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
reviewed
Aug 21, 2025
The respective methods on `DynamicImage` are blocked on the type representation. We can't use any specific pixel type if the goal is preserving the type but `DynamicImage` has no Luma32F variant. For applying a mask we would have to take the parameter type as a non-`DynamicImage` somehow? Feels weird, we should just resolve to add at least 32-bit Luma to the crate, even if we do not add 32-bit LumaAlpha.
Also adds a test suite of the method for different failure mechanisms, pixel types and size mismatches.
197g
force-pushed
the
i1786-extract-alpha
branch
from
4eede62 to
ebcd84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The respective methods on
DynamicImageare blocked on the type representation. We can't use any specific pixel type if the goal is preserving the type butDynamicImagehas no Luma32F variant. For applying a mask we would have to take the parameter type as a non-DynamicImagesomehow? Feels weird, we should just resolve to add at least 32-bit Luma to the crate, even if we do not add 32-bit LumaAlpha.So I don't think this should close #1786 yet.