Fix wrong frame compositing logic #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also thought i might add that this is what the produced gif looks like using the current commit: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the canvas was completely cleared, using the background color, before compositing the current frame on it. this PR corrects that, instead only clearing the rectangle that was occupied by the frame before the one being composited, if it had requested to be disposed of.
along with #85, this PR fixes image-rs/image#2320 and produces the following gif, when using the same code snippet and gif provided:
i'm not entirely sure, however, when the background color provided in the ANIM frame should be used, as this library still produces results that are different from web browsers and other image viewing programs, that seem to just assume a fully transparent bg color in all cases (or maybe only when the animated webp is transparent?)