-
Notifications
You must be signed in to change notification settings - Fork 154
Maintainer Notes
-
Please be very polite in reviews. Some people write very good code, but do not handle criticism well. Try to phrase feedback gently: “This looks good, but could you please fix this part?” or “Could you please simplify this a bit?” The goal is to get the PR into a good shape, not to make the contributor feel bad.
-
Please review PRs carefully before merging. If possible, use Codex or Claude in a cloned repo with the PR checked out, and ask it to review the PR with maximum reasoning.
-
Do not merge everything just because it works locally. Think about all supported paths: install script, updater, DEB/RPM/Pacman packages, Nix, and future upstream Codex updates.
-
If a feature is not needed by almost everyone, it should usually live in
linux-features/and be disabled by default. -
Simpler is better. If the same thing can be done with less code, fewer moving parts, or a smaller patch, please ask for that.
-
It is okay to reject a PR or ask for changes. A useful feature can still create too much long-term maintenance work, bugs, issues, and follow-up fixes.
-
Please think about whether we can realistically support the feature later. Everyone here has limited time and normal work outside this repo.
-
Be especially careful with changes that affect install/update flow, packaging, bundled upstream files, or legal/distribution risk.
-
The goal is to keep the project stable and maintainable.