Skip to content

Conversation

@joev2434
Copy link
Contributor

No description provided.

@joev2434 joev2434 requested review from a-fro and jeffam December 23, 2025 22:02
@jeffam
Copy link
Contributor

jeffam commented Jan 5, 2026

Thanks, @joev2434!

Looks good overall. Here are some change requests:

  • Labels and machine names should be singular, e.g. Card Overlay and card_overlay
  • Please don't use a section in paragraph--card-overlays.html.twig (soon to be paragraph--card-overlay.html.twig), but do include a Composite Heading.
  • The link isn't displaying in the top portion.
  • We might need a media field for an image in the top portion. The NCRS designs seem to show one: https://www.figma.com/design/pfhQCvR2YmyHyKjEXS9gnK/23-24_ILR-WIP?node-id=10894-1087&t=nWm6VPSMPZIfSDs6-4. We'll let you know as soon as we find out if it's required.
  • Some examples of the Card Overlay in figma show the text hidden and revealed on hover. We're trying to figure out if that's a requirement, too.
  • We should switch to Simple Formatting for the Description fields (field_body) on both new paragraph types because it uses Ckeditor 5.

@jeffam
Copy link
Contributor

jeffam commented Jan 6, 2026

Hi @joev2434,

Based on this design mockup, it turns out that we do want the following:

  • A media field to allow for a background image instead of a solid color
  • A setting to enable 'reveal card body text on hover'
  • A setting to increase the font size of the eyebrow heading in the top portion (see the NCRS text in the referenced mockup).

I'll check in with you in Slack to see if this is out of scope. If so, no worries - we'll handle these changes if you just work on the other changes mentioned.

@joev2434 joev2434 closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants