Skip to content

Conversation

@GregWarren14
Copy link
Contributor

Features:

  • Custom Banner: Full-width banner with background image, gradient overlay, breadcrumbs, emphasized title, and topic tags
  • Metadata Sidebar: White card positioned over banner with Published date, Authors, and "Read the Report" CTA button
  • Jump Links Navigation: Horizontal navigation bar below banner that links to page sections
  • Desktop: Horizontal list with downward arrows
  • Mobile: Converts to a dropdown select menu with "JUMP TO:" label
  • Responsive Design: Adapts layout for tablet and mobile breakpoints

jeffam and others added 2 commits December 12, 2025 16:16
…tion

Configure Report Summary content type with fields for authors, emphasized title text, published date, report files, state, topic, representative image, and sections. Set up form and view displays with layout builder enabled.
@GregWarren14 GregWarren14 requested a review from jeffam December 12, 2025 23:09
@jeffam jeffam force-pushed the develop branch 2 times, most recently from 526b25c to 4c10fff Compare December 15, 2025 15:29
@a-fro
Copy link
Contributor

a-fro commented Jan 5, 2026

Hi Greg. Thanks for the PR. Here's the initial feedback based on the review meeting we just had:

  1. The config is currently in a broken state and after importing the site throws an error when trying to view this content type. Please fix the config.
  2. Please render the content type using layout builder rather than a static template. This will allow the layout to be overridden when needed.
  3. Update the banner layout to include a "Sidebar" region. You can place the published date, authors and download field in that region and render per the design
  4. Discuss the design file discrepancies with your design team. The version we see does not have the title over text, but rather, a black box on the left and image on the right of the banner.
  5. Speaking of the title, it's not rendering through the correct font
  6. Please re-use existing fields for the document (field_document), State (field_address) and Topics (field_topics), unless there is some reason I can't think of to reuse one of those fields. If any new fields are needed in a feature branch, please use more generic machine names (the bundle name should rarely, if ever, be included in a machine name), allowing them to be more logically re-used in the future.

I'll mention that it might be good to review some of the other PRs that we eventually merged, and the changes we needed to make. We're seeing the same repeating patterns, such as lots of unnecessary font declarations, that we end up having to strip out. For example, here's such a commit: ilrWebServices/union@13126bb. If you're not making a habit of reviewing the work we do after we merge a PR, I'd definitely suggest it. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants