This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Fix ILLA logo button on hacktoberfest page. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button was clickable before but the cursor did not turn into a pointer because it was a span, not an anchor. This is working fine in Nav of the homepage which uses an anchor tag.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Also, I was wondering whether, if this is approved, it'll be possible to label this with |
|
Hello, just wanted to see if anyone got a chance to look at this. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button is clickable but the cursor does not turn into a pointer because it's a span, not an anchor. The same works fine in Nav of the homepage which uses an anchor tag (ref).
This is the button this PR fixes (unfortunately I'm not able to take a screenshot with a visible mouse pointer):
