Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: syncindex can handle large queryset, allow for nonstandard pk models #10

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

rosscdh-tpg
Copy link
Contributor

Added ability to have non standard ids and large queryset handling for syncindex

  1. allow for large querysets at syncindex
  2. legacy models with non standard pks supported

Copy link
Owner

@ikollipara ikollipara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, but there's some things to address.

In addition, the lack of new tests makes me weary. The new branching and features need tests before I bring it in.

django_meili/management/commands/syncindex.py Outdated Show resolved Hide resolved
django_meili/management/commands/syncindex.py Outdated Show resolved Hide resolved
django_meili/models.py Show resolved Hide resolved
django_meili/querysets.py Outdated Show resolved Hide resolved
django_meili/models.py Outdated Show resolved Hide resolved
@rosscdh-tpg
Copy link
Contributor Author

need to add tests

Copy link
Owner

@ikollipara ikollipara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great, the last thing are the tests and I think we will be good to merge! Thanks for the feature, I really appreciate it and I think it'll add a lot to the library!

@rosscdh-tpg
Copy link
Contributor Author

It all looks great, the last thing are the tests and I think we will be good to merge! Thanks for the feature, I really appreciate it and I think it'll add a lot to the library!

Will probably be in the next few days! :)

@rosscdh-tpg
Copy link
Contributor Author

got some time added tests... also a makefile to make it easier for people to list.. just set it up and go test

Copy link

gitguardian bot commented Oct 24, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 2e97b79 demo/settings.py View secret
- - Generic High Entropy Secret c2c7e97 demo/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rosscdh-tpg
Copy link
Contributor Author

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secret in your pull request

🛠 Guidelines to remediate hardcoded secrets

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

lol yep.. good thing its just a random hex ;)

@rosscdh-tpg
Copy link
Contributor Author

Added tests read for you to review

Copy link
Owner

@ikollipara ikollipara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you so much for writing this up. My only concern is with the Makefile. I'd prefer some shell scripts named setup.sh and test.sh

Makefile Outdated Show resolved Hide resolved
django_meili/tests.py Show resolved Hide resolved
@ikollipara ikollipara merged commit e544354 into ikollipara:main Oct 28, 2024
3 checks passed
@ikollipara
Copy link
Owner

Thank you for this request and listening to my many demands. You were great to work with and I hope to work with you again someday!

@ikollipara ikollipara mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants