-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: syncindex can handle large queryset, allow for nonstandard pk models #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, but there's some things to address.
In addition, the lack of new tests makes me weary. The new branching and features need tests before I bring it in.
need to add tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks great, the last thing are the tests and I think we will be good to merge! Thanks for the feature, I really appreciate it and I think it'll add a lot to the library!
a47d02e
to
45fa656
Compare
Will probably be in the next few days! :) |
got some time added tests... also a makefile to make it easier for people to list.. just set it up and go test |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | 2e97b79 | demo/settings.py | View secret |
- | - | Generic High Entropy Secret | c2c7e97 | demo/settings.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
lol yep.. good thing its just a random hex ;) |
Added tests read for you to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. Thank you so much for writing this up. My only concern is with the Makefile. I'd prefer some shell scripts named setup.sh
and test.sh
Thank you for this request and listening to my many demands. You were great to work with and I hope to work with you again someday! |
Added ability to have non standard ids and large queryset handling for syncindex