Allow weather-fetch to accept an optional city parameter#221
Open
rizzesh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue Does This Fix?
Allow weather-fetch to accept an optional city parameter
Steps Taken To Fix It
I assigned the first positional parameter $1 to the CITY variable, allowing the curl command to fetch weather for a specific city or default to the local IP if left blank.
Testing
Did you test your script locally according to the README.md instructions?
[✅] Yes! The script runs without errors and performs the expected action.
General Checklist
[✅] I have followed the instructions in CONTRIBUTING.md.
[✅] The name of the PR explains what I changed.G.md`.
The name of the PR explains what I changed.