Skip to content

feat(iii-directory): directory namespace, download defaults, fetch paths, cwd skills_folder#128

Merged
sergiofilhowz merged 4 commits into
mainfrom
feat/directory-functions-consolidation
May 13, 2026
Merged

feat(iii-directory): directory namespace, download defaults, fetch paths, cwd skills_folder#128
sergiofilhowz merged 4 commits into
mainfrom
feat/directory-functions-consolidation

Conversation

@sergiofilhowz
Copy link
Copy Markdown
Contributor

Summary

Standardizes iii-directory public function and trigger IDs under a single directory::… namespace, improves directory::skills::download defaults (registry latest, GitHub main with optional branch), lets directory::skills::fetch-skill accept bare skill paths as well as iii:// URIs, and resolves relative skills_folder against the process working directory. Updates BDD tests, on-disk skill docs layout, README/config docs, and downstream callers (turn-orchestrator, shell, harness, openapi.yaml, AGENTS-NEW-WORKER.md).

Motivation

  • Inconsistent prefixes (skills::, prompts::, directory::, registry::) made discovery and documentation harder.
  • Download needed sensible defaults for common registry and GitHub flows.
  • Fetch-skill should match what list returns without forcing callers to prepend iii://.
  • Relative skills_folder should behave predictably (cwd), not relative to the config file location.

Breaking changes

  • Function IDs and trigger type strings changed; any hard-coded old names must be updated (this PR updates in-repo callers).
  • Relative skills_folder is now interpreted from process cwd, not the config file’s directory.

Key changes

Naming

  • skills::*directory::skills::* (e.g. directory::skills::list, directory::skills::download, directory::skills::fetch-skill)
  • prompts::*directory::prompts::*
  • Engine introspection → directory::engine::{functions,triggers,registered-triggers,workers}::{list,info}
  • Registry workers → directory::registry::workers::{list,info}
  • Triggers → directory::skills::on-change, directory::prompts::on-change

Behavior

  • Registry download: worker without version/tag defaults to tag: latest.
  • Repo download: optional branch (default main) passed through to clone.
  • Fetch-skill: bare paths (e.g. agent-memory/observe) normalized to iii://… where appropriate.

Docs & layout

  • iii-directory/skills/ reorganized to mirror namespaces; function_id frontmatter and cross-links updated.
  • README/config examples updated for new IDs and parameters.

How tested

  • cargo test --lib for iii-directory, turn-orchestrator, shell
  • cargo test --test bdd --no-run for iii-directory (compile check)
  • Workspace check that old function ID literals are gone

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@sergiofilhowz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3bc16f59-2e17-4fa5-a7d0-20518489b71a

📥 Commits

Reviewing files that changed from the base of the PR and between 6a227fe and e8c0672.

⛔ Files ignored due to path filters (1)
  • iii-directory/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (64)
  • .github/scripts/tests/test_validate_worker.py
  • .github/scripts/validate_worker.py
  • AGENTS-NEW-WORKER.md
  • harness/docs/iii-skill.md
  • harness/web/src/components/Composer.tsx
  • harness/web/src/menuItems.ts
  • iii-directory/README.md
  • iii-directory/config.yaml
  • iii-directory/skills/directory/engine/functions/info.md
  • iii-directory/skills/directory/engine/functions/list.md
  • iii-directory/skills/directory/engine/registered-triggers/info.md
  • iii-directory/skills/directory/engine/registered-triggers/list.md
  • iii-directory/skills/directory/engine/triggers/info.md
  • iii-directory/skills/directory/engine/triggers/list.md
  • iii-directory/skills/directory/engine/workers/info.md
  • iii-directory/skills/directory/engine/workers/list.md
  • iii-directory/skills/directory/function-info.md
  • iii-directory/skills/directory/function-list.md
  • iii-directory/skills/directory/registered-trigger-info.md
  • iii-directory/skills/directory/registered-trigger-list.md
  • iii-directory/skills/directory/registry/workers/info.md
  • iii-directory/skills/directory/registry/workers/list.md
  • iii-directory/skills/directory/skills/download.md
  • iii-directory/skills/directory/skills/fetch-skill.md
  • iii-directory/skills/directory/skills/list.md
  • iii-directory/skills/directory/trigger-info.md
  • iii-directory/skills/directory/trigger-list.md
  • iii-directory/skills/directory/worker-info.md
  • iii-directory/skills/directory/worker-list.md
  • iii-directory/skills/index.md
  • iii-directory/src/config.rs
  • iii-directory/src/functions/directory.rs
  • iii-directory/src/functions/download.rs
  • iii-directory/src/functions/mod.rs
  • iii-directory/src/functions/prompts.rs
  • iii-directory/src/functions/registry.rs
  • iii-directory/src/functions/skills.rs
  • iii-directory/src/how_to.rs
  • iii-directory/src/lib.rs
  • iii-directory/src/main.rs
  • iii-directory/src/sources/git.rs
  • iii-directory/src/trigger_types.rs
  • iii-directory/tests/common/workers.rs
  • iii-directory/tests/features/directory_functions.feature
  • iii-directory/tests/features/directory_triggers.feature
  • iii-directory/tests/features/directory_workers.feature
  • iii-directory/tests/features/download_registry.feature
  • iii-directory/tests/features/download_repo.feature
  • iii-directory/tests/features/prompts.feature
  • iii-directory/tests/features/read.feature
  • iii-directory/tests/features/registry_worker_info.feature
  • iii-directory/tests/features/registry_worker_list.feature
  • iii-directory/tests/steps/directory.rs
  • iii-directory/tests/steps/download_registry.rs
  • iii-directory/tests/steps/download_repo.rs
  • iii-directory/tests/steps/prompts.rs
  • iii-directory/tests/steps/read.rs
  • iii-directory/tests/steps/registry.rs
  • shell/src/lib.rs
  • shell/src/main.rs
  • turn-orchestrator/src/agent_call.rs
  • turn-orchestrator/src/states/functions.rs
  • turn-orchestrator/src/states/provisioning.rs
  • turn-orchestrator/src/system_prompt.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/directory-functions-consolidation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…ths, cwd skills_folder

- directory::skills::download: default registry tag to latest; add branch (default main) for repo clones
- directory::skills::fetch-skill: accept bare skill paths and iii:// URIs
- Reorganize iii-directory/skills/ markdown to match new namespaces
- Update BDD tests, README, and callers (turn-orchestrator, shell, harness, openapi, AGENTS-NEW-WORKER)
@sergiofilhowz sergiofilhowz force-pushed the feat/directory-functions-consolidation branch from 250fafa to 42de680 Compare May 13, 2026 17:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

skill-check — worker

6 verified, 19 skipped (no docs/).

1 error across the verified workers.

File Line Severity Violation
auth-credentials/skills/list_providers.md 14 error auth::status is referenced without confirming it's a real registered function on this worker; the rule against function-table drift aside, ambiguous cross-references to functions on the same worker should use iii:// links per skill-doc conventions — verify auth::status exists and link it as iii://auth-credentials/status (or remove the reference).

@sergiofilhowz sergiofilhowz merged commit 125c5bf into main May 13, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants