docs(skills): worker/sandbox skill bodies for agent registry#1627
Open
andersonleal wants to merge 2 commits into
Open
docs(skills): worker/sandbox skill bodies for agent registry#1627andersonleal wants to merge 2 commits into
andersonleal wants to merge 2 commits into
Conversation
Content-only review branch. Pairs with feature/worker-manager-trigger,
which carries the code that registers these bodies with the `skills`
worker on boot (via include_str! from the same paths).
This branch is for prose review in isolation; it does not build
standalone — the include_str! call sites live on the code branch.
Content map:
crates/iii-worker/src/cli/worker_manager_daemon/skills/
router.md iii://worker — router for the 8 worker::* ops
add.md iii://worker/add
remove.md iii://worker/remove
update.md iii://worker/update
start.md iii://worker/start
stop.md iii://worker/stop
list.md iii://worker/list
clear.md iii://worker/clear
schema.md iii://worker/schema
crates/iii-worker/src/sandbox_daemon/skills/
router.md iii://sandbox — router for the 4 sandbox::* ops
create.md iii://sandbox/create
exec.md iii://sandbox/exec
stop.md iii://sandbox/stop
list.md iii://sandbox/list
Each leaf carries a uniform agent-facing shape:
H1 with one-line action
1-2 sentence summary (non-obvious contract surfaced)
- id / timeout / idempotent / request / response (bulleted metadata)
## Example (complete request + response payloads)
## Errors (every code with cause + fix hint)
Total ~16 KiB across 14 files (worker 9.7 KiB, sandbox 6.3 KiB).
Sandbox bodies cross-reference against the actual on-disk daemon
(crates/iii-worker/src/sandbox_daemon/{create,exec,stop,list,errors}.rs)
— field names, codes, and envelope shapes are pinned to the real
sdk_contract. Each leaf validates against the planned
crate::skills::validate_leaf (50–4096 bytes, H1 required,
[a-z0-9_-] segments).
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughAdds documentation-only API specs for two daemons: worker-manager ( ChangesWorker Manager Daemon Skills
Sandbox Daemon Skills
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ytallo
previously approved these changes
May 12, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (7)
crates/iii-worker/src/cli/worker_manager_daemon/skills/start.md (1)
34-34: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 34.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/start.md` at line 34, Add a trailing newline to the end of the Markdown file "crates/iii-worker/src/cli/worker_manager_daemon/skills/start.md" so the file ends with a final newline character; simply open start.md and ensure there is an empty newline after the current last line (line 34) and save the file.crates/iii-worker/src/cli/worker_manager_daemon/skills/list.md (1)
38-38: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 38.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/list.md` at line 38, The file crates/iii-worker/src/cli/worker_manager_daemon/skills/list.md is missing a final newline; open that file and add a single newline character at the end of the file (ensure the last line ends with a newline), save and commit so the file ends with a trailing newline.crates/iii-worker/src/cli/worker_manager_daemon/skills/update.md (1)
34-34: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 34.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/update.md` at line 34, The file update.md is missing a trailing newline at the end; open update.md and add a final newline character after line 34 (ensure the file ends with a newline) so the file conforms to POSIX text file conventions and prevents tooling diffs.crates/iii-worker/src/cli/worker_manager_daemon/skills/add.md (1)
35-35: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 35.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/add.md` at line 35, The file add.md is missing a final newline at EOF; open add.md (the skills/add.md document) and add a single trailing newline character at the end of the file so the file ends with a blank line (ensure the last line 35 ends with a newline).crates/iii-worker/src/cli/worker_manager_daemon/skills/remove.md (1)
26-26: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 26.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/remove.md` at line 26, The file remove.md is missing a trailing newline at EOF; open the file (crates/iii-worker/src/cli/worker_manager_daemon/skills/remove.md) and add a single final newline character after the last line (line 26) so the file ends with a newline.crates/iii-worker/src/cli/worker_manager_daemon/skills/schema.md (1)
31-31: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 31.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/schema.md` at line 31, Add a final newline at the end of the skills schema markdown document so the file ends with a trailing newline; open the skills schema file (schema.md) and ensure the last line (the current end-of-file) is followed by a single newline character, then save the file.crates/iii-worker/src/cli/worker_manager_daemon/skills/clear.md (1)
29-29: ⚡ Quick winAdd a final newline.
The file is missing a final newline after line 29.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/clear.md` at line 29, Add a missing final newline to the end of the markdown file clear.md by ensuring the file ends with a single newline character (i.e., append a trailing newline after the current last line). This is a trivial edit—open clear.md and add a final newline so the file terminates with a newline character.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/add.md`:
- Line 35: The file add.md is missing a final newline at EOF; open add.md (the
skills/add.md document) and add a single trailing newline character at the end
of the file so the file ends with a blank line (ensure the last line 35 ends
with a newline).
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/clear.md`:
- Line 29: Add a missing final newline to the end of the markdown file clear.md
by ensuring the file ends with a single newline character (i.e., append a
trailing newline after the current last line). This is a trivial edit—open
clear.md and add a final newline so the file terminates with a newline
character.
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/list.md`:
- Line 38: The file
crates/iii-worker/src/cli/worker_manager_daemon/skills/list.md is missing a
final newline; open that file and add a single newline character at the end of
the file (ensure the last line ends with a newline), save and commit so the file
ends with a trailing newline.
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/remove.md`:
- Line 26: The file remove.md is missing a trailing newline at EOF; open the
file (crates/iii-worker/src/cli/worker_manager_daemon/skills/remove.md) and add
a single final newline character after the last line (line 26) so the file ends
with a newline.
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/schema.md`:
- Line 31: Add a final newline at the end of the skills schema markdown document
so the file ends with a trailing newline; open the skills schema file
(schema.md) and ensure the last line (the current end-of-file) is followed by a
single newline character, then save the file.
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/start.md`:
- Line 34: Add a trailing newline to the end of the Markdown file
"crates/iii-worker/src/cli/worker_manager_daemon/skills/start.md" so the file
ends with a final newline character; simply open start.md and ensure there is an
empty newline after the current last line (line 34) and save the file.
In `@crates/iii-worker/src/cli/worker_manager_daemon/skills/update.md`:
- Line 34: The file update.md is missing a trailing newline at the end; open
update.md and add a final newline character after line 34 (ensure the file ends
with a newline) so the file conforms to POSIX text file conventions and prevents
tooling diffs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5c6193bd-26ce-4718-a4df-9ed704610056
📒 Files selected for processing (14)
crates/iii-worker/src/cli/worker_manager_daemon/skills/add.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/clear.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/list.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/remove.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/router.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/schema.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/start.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/stop.mdcrates/iii-worker/src/cli/worker_manager_daemon/skills/update.mdcrates/iii-worker/src/sandbox_daemon/skills/create.mdcrates/iii-worker/src/sandbox_daemon/skills/exec.mdcrates/iii-worker/src/sandbox_daemon/skills/list.mdcrates/iii-worker/src/sandbox_daemon/skills/router.mdcrates/iii-worker/src/sandbox_daemon/skills/stop.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/iii-worker/src/cli/worker_manager_daemon/skills/(9 worker ops) andcrates/iii-worker/src/sandbox_daemon/skills/(5 sandbox ops). These are the prose theskillsworker will register at boot viainclude_str!from the companion code branchfeature/worker-manager-trigger.- id / timeout / idempotent / request / responsemetadata + complete request/response example + per-code error list.validate_leafwindow). Worker bodies cross-reference againstcrates/iii-worker/src/core/{types.rs,error.rs}andcli/worker_manager_daemon.rs. Sandbox bodies cross-reference againstcrates/iii-worker/src/sandbox_daemon/{create,exec,stop,list,errors}.rs.Context
This branch is content-only and does not build standalone. The
include_str!call sites live onfeature/worker-manager-trigger. Both branches land together; reviewing prose in isolation here keeps the diff readable.Examples use
image-resize(real worker at https://workers.iii.dev/workers/image-resize) so agents reading the docs can copy-paste a working call rather than chase a placeholder.Test plan
WorkerOpErrorKindvariant on main (grep -hoE 'W[0-9]{3}' .../skills/*.md⊆error.rs).SandboxErrorCodevariant on main.- id:matches aregister_function/register_function_withcall inworker_manager_daemon.rs/sandbox_daemon/mod.rs.core/types.rs(worker) andsandbox_daemon/{create,exec,stop,list}.rs(sandbox) — includingsandbox_idvsid,env: Vec<String>not map,exit_codenotrc, etc.wc -c .../skills/*.md).Summary by CodeRabbit