Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply workaround for Ubuntu Python 3.12-path-R CI failure #553

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Dec 12, 2024

This PR tries to implement the workaround identified in actions/runner-images#11137 for the CI failure on Ubuntu 24.04 with Python 3.12.
I'm not sure which part(s) of the suggested workaround are actually required, some seem to evaluate to no-ops (e.g. libssl-dev is already the newest version (3.0.2-0ubuntu1.18).). I'll play around with the steps to see if the workaround can be made more concise.

How to review

  • Read the diff and note that the CI checks all pass (in particular the one on ubuntu-latest-py3.12).

PR checklist

  • Continuous integration checks all ✅
  • Update tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update release notes. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration label Dec 12, 2024
@glatterf42 glatterf42 self-assigned this Dec 12, 2024
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from c73618f to 32a862c Compare December 12, 2024 10:12
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (02dadfa) to head (c5082e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #553     +/-   ##
=======================================
- Coverage   98.9%   98.9%   -0.1%     
=======================================
  Files         44      44             
  Lines       4790    4790             
=======================================
- Hits        4740    4739      -1     
- Misses        50      51      +1     

see 1 file with indirect coverage changes

@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch 6 times, most recently from 5a0cf10 to 813b7a4 Compare December 12, 2024 10:50
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch 2 times, most recently from 7272227 to 6e7a5fe Compare December 12, 2024 14:14
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from 6e7a5fe to d93ed2a Compare December 13, 2024 07:37
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from 37ca185 to e8d76d5 Compare December 20, 2024 12:15
@glatterf42
Copy link
Member Author

glatterf42 commented Dec 20, 2024

Funny enough, calling reticulate::py_config() fixes the error on ubuntu, but causes the other OSs to crash. So now we have a step specific to ubuntu-latest-py3.12, which does not even need the IRkernel::installspec() (as do the other ubuntu runs).

Any remaining test error is just flaky.

@glatterf42 glatterf42 changed the title Apply suggested workaround for affected CI test Apply workaround for Ubuntu Python 3.12-path-R CI failure Dec 20, 2024
Copy link

@measrainsey measrainsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @glatterf42 for the changes and given that the tests are failing because they're flaky, this is good with me

@glatterf42 glatterf42 merged commit d760143 into main Dec 20, 2024
21 checks passed
@glatterf42 glatterf42 deleted the fix/ubuntu-tutorials-r-jupyter branch December 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants