Skip to content

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jul 22, 2025

I'd need some help with Stimulus, here I made the changes directly in aaa-auto.R to check the test results.

@maelle maelle requested a review from schochastics July 22, 2025 13:41
@schochastics
Copy link
Contributor

I am still a stimulus newbie. Is the change in types-RR.yaml not yet enough?

@maelle
Copy link
Contributor Author

maelle commented Jul 22, 2025

Is the change in types-RR.yaml not yet enough?

It should be, with the right command.

@schochastics
Copy link
Contributor

So we need to find the right command? 🕵‍♂️

@maelle
Copy link
Contributor Author

maelle commented Jul 22, 2025

Yep, but only if you agree with the change.

@maelle
Copy link
Contributor Author

maelle commented Aug 21, 2025

docker run --rm -ti --platform linux/amd64 -v $(pwd):/root/workspace ghcr.io/cynkra/rig-ubuntu-igraph:main make -f Makefile-cigraph

@maelle maelle requested a review from krlmlr August 27, 2025 09:24
@maelle maelle marked this pull request as ready for review August 27, 2025 09:24
@krlmlr
Copy link
Contributor

krlmlr commented Sep 4, 2025

Running revdepchecks for this and #1981.

@krlmlr
Copy link
Contributor

krlmlr commented Sep 7, 2025

Too risky, seven new failures after this or the other PR. Let's wait.

@krlmlr krlmlr marked this pull request as draft September 7, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants